[PATCH] v8: fix missing callback in heap utils destroy
authorRuben Bridgewater <ruben.bridgewater@datadoghq.com>
Mon, 30 Jun 2025 11:51:40 +0000 (13:51 +0200)
committerJérémy Lal <kapouer@melix.org>
Thu, 5 Mar 2026 10:05:11 +0000 (11:05 +0100)
commit9d6aaf3017d58913a8dee95a5fa3ae626dec7d38
tree80ba5104b30dcf31863e3b8c28e07b4a614a18ed
parentedd8164fb14b1cdd0985eeb1ae3e7307c08ae8e6
[PATCH] v8: fix missing callback in heap utils destroy

This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.

PR-URL: https://github.com/nodejs/node/pull/58846
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
Gbp-Pq: Topic sec
Gbp-Pq: Name 19-v8-fix-missing-callback-in-heap-utils-destroy.patch
lib/internal/heap_utils.js
test/sequential/test-heapdump.js